feat: initEccLib skip verification (v7) #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
force-pushed
the
fboucquez/feat/skip-ecc-verification
branch
from
51cbf32 to
af1f2d7
Compare
fboucquez
changed the title
fboucquez
force-pushed
the
fboucquez/feat/skip-ecc-verification
branch
from
af1f2d7 to
14e066c
Compare
Member
|
Match this to the other one (no need for the version or CHANGELOG stuff though.) and I'll merge it. |
Contributor
Author
|
Updated, I've added the CHANGELOG like it was in the v6 version |
junderw
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifyEcc could be expensive, taking up to 500 ms to finish on some devices. This PR allows the client code to avoid running the verification on run with a flag. Devs can run the verification on unit tests to verify if the provided ECC is correct.